Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/examples/02_sql_vs_dsl/sql_vs_dsl_nb.ipynb`:
- Around line 19-20: The Markdown string in the notebook cell currently has an
extra trailing backtick: "\"**Prerequisites:** `pip install
motley-slayer[examples]` (jafgen is installed by the cell below)`\""; edit that
string (the notebook cell content containing the Prerequisites line) to remove
the final backtick so it reads "**Prerequisites:** `pip install
motley-slayer[examples]` (jafgen is installed by the cell below)".
In `@docs/examples/03_auto_ingest/auto_ingest_nb.ipynb`:
- Line 17: The Markdown string currently contains a stray trailing backtick:
"**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed
by the cell below)`"; edit that cell text to remove the final backtick so it
reads "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is
installed by the cell below)" and save the notebook.
In `@docs/examples/04_time/time_nb.ipynb`:
- Line 16: Remove the stray trailing backtick from the Markdown string in the
notebook cell (the line containing "**Prerequisites:** `pip install
motley-slayer[examples]` (jafgen is installed by the cell below)`"); update that
string to end without the extra backtick so it reads correctly as Markdown.
In `@docs/examples/05_joined_measures/joined_measures_nb.ipynb`:
- Line 18: Fix the malformed inline-code in the notebook cell that contains the
string "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is
installed by the cell below)`" by removing the extra trailing backtick so the
backticks correctly wrap the pip command; update that cell’s markdown text to
"**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed
by the cell below)".
In `@docs/examples/05_joins/joins_nb.ipynb`:
- Line 20: Fix the malformed Markdown in the prerequisites string by removing
the extra trailing backtick: change the cell content line that currently reads
"**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed
by the cell below)`" to properly close backticks only around the pip command
(i.e., no trailing backtick after the parenthesis) so the text around the symbol
remains valid Markdown.
In `@docs/examples/06_multistage_queries/multistage_queries_nb.ipynb`:
- Line 16: Edit the notebook cell containing the prerequisites string
"**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed
by the cell below)`" and remove the stray trailing backtick at the end so the
Markdown becomes well-formed (i.e., end the line with "...below)" instead of
"...below)`"). Ensure the updated cell preserves the inline code backticks
around pip install only.
In `@docs/examples/07_aggregations/aggregations_nb.ipynb`:
- Around line 14-15: The Markdown in the notebook's prerequisites string has an
extra trailing backtick that breaks inline-code formatting; edit the string in
the cell containing "**Prerequisites:** `pip install motley-slayer[examples]`
(jafgen is installed by the cell below)`" to remove the stray final backtick so
it becomes "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is
installed by the cell below)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2972399e-2002-43e8-977a-4a1dde799eb5
📒 Files selected for processing (9)
.github/workflows/ci.ymldocs/examples/02_sql_vs_dsl/sql_vs_dsl_nb.ipynbdocs/examples/03_auto_ingest/auto_ingest_nb.ipynbdocs/examples/04_time/time_nb.ipynbdocs/examples/05_joined_measures/joined_measures_nb.ipynbdocs/examples/05_joins/joins_nb.ipynbdocs/examples/06_multistage_queries/multistage_queries_nb.ipynbdocs/examples/07_aggregations/aggregations_nb.ipynbpyproject.toml
docs/examples/06_multistage_queries/multistage_queries_nb.ipynb
Outdated
Show resolved
Hide resolved
AivanF
force-pushed
the
aivan/2026-04-13-jafgen-dep
branch
from
1765a04 to
57296b9
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/examples/05_joins/joins_nb.ipynb (1)
20-20:⚠️ Potential issue | 🟡 MinorFix malformed Markdown in prerequisites line.
Line 20 still has an extra trailing backtick after the parenthetical text, which breaks Markdown rendering.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/examples/05_joins/joins_nb.ipynb` at line 20, The prerequisites Markdown line contains an extra trailing backtick in the string "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed by the cell below)`" which breaks rendering; edit that cell (the line containing the prerequisites string) to remove the stray backtick at the end so it reads "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen is installed by the cell below)".
🧹 Nitpick comments (1)
docs/examples/05_joins/joins_nb.ipynb (1)
29-32: Prefer%pipover!pipin notebook install cells.Line 32 should use
%pipto ensure installation goes into the active Jupyter kernel environment.Suggested change
- "!pip install -q git+https://github.com/rossbowen/jaffle-shop-generator.git@09557a1118b000071f8171aa97d54d5029bf0f0b" + "%pip install -q git+https://github.com/rossbowen/jaffle-shop-generator.git@09557a1118b000071f8171aa97d54d5029bf0f0b"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/examples/05_joins/joins_nb.ipynb` around lines 29 - 32, Replace the shell-style notebook install invocation using "!pip install -q git+https://github.com/rossbowen/jaffle-shop-generator.git@09557a1118b000071f8171aa97d54d5029bf0f0b" with a magic-style invocation using "%pip" so the package installs into the active Jupyter kernel; update the notebook cell that contains the jaffle-shop-generator install command to use "%pip install -q ..." instead of leading "!" to ensure the installation targets the running kernel.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/examples/05_joins/joins_nb.ipynb`:
- Line 20: The prerequisites Markdown line contains an extra trailing backtick
in the string "**Prerequisites:** `pip install motley-slayer[examples]` (jafgen
is installed by the cell below)`" which breaks rendering; edit that cell (the
line containing the prerequisites string) to remove the stray backtick at the
end so it reads "**Prerequisites:** `pip install motley-slayer[examples]`
(jafgen is installed by the cell below)".
---
Nitpick comments:
In `@docs/examples/05_joins/joins_nb.ipynb`:
- Around line 29-32: Replace the shell-style notebook install invocation using
"!pip install -q
git+https://github.com/rossbowen/jaffle-shop-generator.git@09557a1118b000071f8171aa97d54d5029bf0f0b"
with a magic-style invocation using "%pip" so the package installs into the
active Jupyter kernel; update the notebook cell that contains the
jaffle-shop-generator install command to use "%pip install -q ..." instead of
leading "!" to ensure the installation targets the running kernel.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d19aeb08-b41a-44c9-84e3-85fdf7f9aba4
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
.github/workflows/ci.ymldocs/examples/02_sql_vs_dsl/sql_vs_dsl_nb.ipynbdocs/examples/03_auto_ingest/auto_ingest_nb.ipynbdocs/examples/04_time/time_nb.ipynbdocs/examples/05_joined_measures/joined_measures_nb.ipynbdocs/examples/05_joins/joins_nb.ipynbdocs/examples/06_multistage_queries/multistage_queries_nb.ipynbdocs/examples/07_aggregations/aggregations_nb.ipynbpyproject.toml
✅ Files skipped from review due to trivial changes (1)
- docs/examples/04_time/time_nb.ipynb
🚧 Files skipped from review as they are similar to previous changes (6)
- .github/workflows/ci.yml
- docs/examples/06_multistage_queries/multistage_queries_nb.ipynb
- docs/examples/03_auto_ingest/auto_ingest_nb.ipynb
- docs/examples/05_joined_measures/joined_measures_nb.ipynb
- docs/examples/07_aggregations/aggregations_nb.ipynb
- docs/examples/02_sql_vs_dsl/sql_vs_dsl_nb.ipynb
PyPI rejects projects with dependencies outside of PyPI, and we need that specific commit (not merged still) that fixes a bug.
AivanF
force-pushed
the
aivan/2026-04-13-jafgen-dep
branch
from
57296b9 to
099bebf
Compare
Member
|
You committed the notebooks without the run results, can you please run the notebooks and commit them including execution results? |
ZmeiGorynych
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPI rejects projects with dependencies outside of PyPI, and we need that specific commit (not merged still) that fixes a bug.
Summary by CodeRabbit
Chores
Documentation