Resample fix#1438
Merged
carsen-stringer merged 3 commits intomainfrom Apr 30, 2026
Merged
Conversation
mrariden
commented
Apr 28, 2026
|
|
||
| if resize is not None: | ||
| dynamics_logger.warning("Resizing is deprecated in v4.0.1+") | ||
| if len(resize) == 2: |
Collaborator
Author
There was a problem hiding this comment.
This block was removed when I purged all resample/rescale code from CP4. It's verbatim cp3, and now actually does what the function name implies.
Collaborator
Author
|
Passing tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jeskowagner found that masks weren't being correctly resized and proposed a fix in #1434. This fix is preferred to be more consisted with the CP3 code.
Added a test that fails to highlight the issue, and adding the fix causes the test to pass.