[FEAT] 카카오 로그인, 회원탈퇴 구현#6
Merged
EunbeenDev merged 2 commits intoMove-Log:developfrom Dec 30, 2024
Merged
Conversation
EunbeenDev
approved these changes
Dec 30, 2024
Member
EunbeenDev
left a comment
EunbeenDev
left a comment
There was a problem hiding this comment.
로그 출력 방식만 코멘트 확인해주시면 감사하겠습니다:)
고생하셨습니다~~
Comment on lines
+40
to
+43
| private OidcProvider getProvider(Provider provider) { | ||
| OidcProvider oidcProvider = authProviderMap.get(provider); | ||
| System.out.println("oidcProvider = " + oidcProvider); | ||
| System.out.println("oidcProvider.getProviderId = " + oidcProvider.getProviderId("eyJraWQiOiI5ZjI1MmRhZGQ1ZjIzM2Y5M2QyZmE1MjhkMTJmZWEiLCJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJhdWQiOiIxYzNjNDNiZTViYmYxMWVkNjI1ZTMyMDZhODI2ZTUzZSIsInN1YiI6IjM2Mzc0OTc0ODkiLCJhdXRoX3RpbWUiOjE3MjE5MTI2NzcsImlzcyI6Imh0dHBzOi8va2F1dGgua2FrYW8uY29tIiwiZXhwIjoxNzIxOTU1ODc3LCJpYXQiOjE3MjE5MTI2NzcsImVtYWlsIjoic3NtamgwMzAxQG5hdmVyLmNvbSJ9.cIMebTedEde8BrUUasnRJivdFJmyL62kvUDepnK7NlHp5dl9ygYqZNnoerDT5YU6bta503Mzp9-7U_MBRdqNPr7NXwvJ76NEAJcp3UwCV7DJJRlKMZv1PySqUJmpZiCwmCYhJV-UvEU2G9NF0mK_1CQ6-c2YnbAzxtf8DJ9jib6M8jyHD2-_FUM21IX8_0Uvb4TbwCwfSh8GaBLZKNgSAseq5Pf_vnVWbt38loRvfYhGBNcXey-BFQF3aiG8v0E9SaH4D93UhueFotXplrGg2I2UP7VEkkL1vDhb0I2sO82zELKBxYWaadzyCtv8dobB_blxOy5lagy6L4w2iBBMsw")); |
Member
There was a problem hiding this comment.
이러한 부분에서 print문으로 출력하는 것보다는 @slf4j를 사용해서 로그를 출력하는 방식은 어떨까요??
EunbeenDev
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌻 Summary
🌱 To be noted
💫 issue number
☑️ Checklist
💡 Comment