Conversation
## About The Pull Request helps remove the shitty white flashing, way way less noticeable so like this will still happen on first mount of each♻️reused tgui window♻️, but subsequent full **full** rerenders won't look shitty ugly gross pictured: me spamming refresh https://github.com/user-attachments/assets/706cde5f-06a0-4658-a489-8038d2c517fe i can't fix first mount unless lummox gives us the ability to set `WebView2.DefaultBackgroundColor` via `browse()` which, ..... LOL feel free to merge or close or edit or whatever this is just a courtesy upstream PR, no warranty here's the song i was listening to while i wrote this [](https://open.spotify.com/track/2dYwmQKGTqHEFEafnNwr60) ## Why It's Good For The Game obviously not as good on different themes than default but still better than shitty white i don't think you even have light mode, so no 5% of users or whatever to complain there either ## Changelog :cl: fix: white TGUI window flashing should be less present /:cl: --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
## About The Pull Request i hate this shitty flashing bullshit, i develop a real game that should be taken seriously: https://github.com/user-attachments/assets/eee05688-14d9-486d-8c89-deeb3ab4d45e what if we could live in a world without it oh yeah i did that (again) https://github.com/user-attachments/assets/351a3243-7835-488a-8d5e-405f640660b8 ## Why It's Good For The Game i'm just upstreaming this so it's less work for me to port changes in 2 years if you don't think this shit is good you should look at this spoiler: <details> <summary>bad opinion zone</summary>  </details> direct all people who have billion pixel tall screens who are scared of a single pixel flashing for a frame towards the goonstation ideas and suggestions subforum oh i also wrote this section of the code originally a year ago in #86868 lol, but that only fixed it in IE not wv2 ## Changelog :cl: fix: tgui windows should now stop flashing for a single frame elsewhere when opening /:cl:
## About The Pull Request 1 pixel (less on most monitor resolutions, it'll render as subpixels only) flashing dark grey is not noticeable this overcompensation is not needed tested on goon and honestly i had to be looking really hard at the subpixels in the top left to actually even notice ## Why It's Good For The Game less problems for people with weird setups or buggy monitors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the annoying white flash when opening TGUI windows. Most based fix thanks Zewaka