Skip to content

Added enums for safe strings#145

Merged
SemyonSinchenko merged 4 commits intoMrPowers:mainfrom
moshesar:added_enums
Apr 14, 2025
Merged

Added enums for safe strings#145
SemyonSinchenko merged 4 commits intoMrPowers:mainfrom
moshesar:added_enums

Conversation

@moshesar
Copy link
Copy Markdown
Contributor

Added Enums for a consistent, safer strings usage in code

Comment thread chispa/schema_comparer.py Outdated
Comment thread chispa/common_enums.py Outdated
Copy link
Copy Markdown
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution, @moshesar
I will leave it as is until the end of the week in the case of more comments. cc: @MrPowers @fpgmaas

@moshesar
Copy link
Copy Markdown
Contributor Author

Hi @SemyonSinchenko can this be merged ?

@SemyonSinchenko
Copy link
Copy Markdown
Collaborator

Hi @SemyonSinchenko can this be merged ?

I'm sorry, I forgot about his one :(

@SemyonSinchenko SemyonSinchenko merged commit 57db7b6 into MrPowers:main Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants