This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Error handling for circular references#36
Merged
Mte90 merged 1 commit intoMte90:masterfrom Oct 16, 2018
Merged
Conversation
_Part of my Hacktober effort, sorry if this not very sophisticated_ ## What ## Following Mte90#35, I’ve added: - error handling for: - circular references; - use of non-supported languages; - some modularity. ## Comment ## I could not find a list of supported languages, so I’m just catching the file error; there should be a way to generate both the detection and the copy of the error message from the contents of the `/words/` file. I’m not sure if there could be other error in either `store_new_argument` function. I have not found a testing framework.
Owner
|
Thanks for your contribution! |
Mte90
reviewed
Oct 16, 2018
| def store_new_argument(_args_): | ||
| try: | ||
| lang_path = script_path + '/words/' + _args_.lang + '.json' | ||
| typo_data = open_typo_file(lang_path) |
Owner
There was a problem hiding this comment.
I forgot to add a check of the language file f exist, good catch!
Mte90
approved these changes
Oct 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of my Hacktober effort, sorry if this not very sophisticated
What
Following #35, I’ve added:
Comment
I could not find a list of supported languages, so I’m just catching the file error; there should be a way to generate both the detection and the copy of the error message from the contents of the
/words/file.I’m not sure if there could be other error in either
store_new_argumentfunction.I have not found a testing framework.