[pull] NetHack-3.7 from NetHack:NetHack-3.7#555
Merged
pull[bot] merged 4 commits intoMu-L:NetHack-3.7from Sep 23, 2022
Merged
Conversation
added 4 commits
September 22, 2022 15:34
Someone asked whether the 'magr' argument to artifact_hit() can be Null or not since the code sometimes checks whether it is Null and other times uses it unconditonally. The answer is "it depends." Can't reply to asker due to forced anonymity when the contact form was submitted.
Add a comment to the effect that engraving with Fire Brand doesn't cause it to become dull. [I'm not sure that is the behavior we really want. It seems like an unintended side-effect of changing Fire Brand's engrave type to BURN.]
In the quest branch, dbg_bottom() returns a barrier level rather than actual bottom. Do things the same way for the gehennom branch.
Give a [probably pointless] hint if the player tries to move '>' while on the vibrating square.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )