Conversation
https://bugs.webkit.org/show_bug.cgi?id=296521 Reviewed by Darin Adler. Converts the `stroke-width` and `-webkit-text-stroke-width` properties to strong style types. To make this interpolation work, deduction guides were needed for `StyleTypeWrapper` to allow different types of RenderStyle getter/setter variations. This has the nice side-effect of removing the need for a bunch of explicit types in declarations. * Source/WebCore/CMakeLists.txt: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/values/primitives/CSSPrimitiveNumericUnits.h: * Source/WebCore/rendering/RenderTreeAsText.cpp: * Source/WebCore/rendering/style/RenderStyle.cpp: * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: * Source/WebCore/rendering/style/RenderStyleSetters.h: * Source/WebCore/rendering/style/SVGRenderStyle.h: * Source/WebCore/rendering/style/StyleRareInheritedData.cpp: * Source/WebCore/rendering/style/StyleRareInheritedData.h: * Source/WebCore/style/StyleBuilderConverter.h: * Source/WebCore/style/StyleBuilderCustom.h: * Source/WebCore/style/StyleExtractorConverter.h: * Source/WebCore/style/StyleExtractorSerializer.h: * Source/WebCore/style/StyleInterpolationWrappers.h: * Source/WebCore/style/values/fill-stroke/StyleStrokeWidth.cpp: Added. * Source/WebCore/style/values/fill-stroke/StyleStrokeWidth.h: Added. * Source/WebCore/style/values/non-standard/StyleWebKitTextStrokeWidth.cpp: Added. * Source/WebCore/style/values/non-standard/StyleWebKitTextStrokeWidth.h: Added. * Source/WebCore/style/values/primitives/StylePrimitiveNumeric.h: * Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h: * Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Evaluation.h: * Source/WebCore/svg/SVGLengthContext.cpp: * Source/WebCore/svg/SVGLengthContext.h: Canonical link: https://commits.webkit.org/297906@main
https://bugs.webkit.org/show_bug.cgi?id=296522 Reviewed by Darin Adler. Converts the properties `outline-width` and `outline-offset` to use strong style types. * Source/WebCore/CMakeLists.txt: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/rendering/BorderEdge.cpp: * Source/WebCore/rendering/BorderPainter.cpp: * Source/WebCore/rendering/RenderElement.cpp: * Source/WebCore/rendering/RenderImage.cpp: * Source/WebCore/rendering/style/OutlineValue.cpp: * Source/WebCore/rendering/style/OutlineValue.h: * Source/WebCore/rendering/style/RenderStyle.cpp: * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: * Source/WebCore/rendering/style/RenderStyleSetters.h: * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: * Source/WebCore/style/values/backgrounds/StyleLineWidth.cpp: Added. * Source/WebCore/style/values/backgrounds/StyleLineWidth.h: Added. Canonical link: https://commits.webkit.org/297907@main
https://bugs.webkit.org/show_bug.cgi?id=296529 rdar://156821446 Reviewed by Sam Weinig. Use the enum values provided by CoreVideo to describe IOSurface formats. Declare some types that will be used in a future PR, using their SPI names since the headers aren't yet stable. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/spi/cf/CoreVideoSPI.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: (WebCore::createSurface): (WebCore::formatFromSurface): Canonical link: https://commits.webkit.org/297908@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )