Conversation
A couple of pointer parameters should be references instead. Change-Id: Ic1850d9330194374f7fe2108815267ede6f3ca32 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4021971 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
The way this was originally written blows up on large enough targets (like...Chromium :/). This change adds a set for amortized constant time lookup of whether a FUNC already exists at a given address. Bug: google-breakpad:751 Change-Id: I10a322da70f769c106e1e5f5b2dc3dc3f79444fd Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4031580 Reviewed-by: Mark Mentovai <mark@chromium.org>
- We were appending a CRLF to uploaded files, which is okay for Breakpad symbols but breaks binaries (PE/PDB). - Removed the CRLF after files in the request body to fix issue. Tested with Breakpad, PE, and PDB uploads. Change-Id: I95ee7c51bf981cdb2e55cc720a7813cf7afa21ce Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4038506 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Zequan Wu <zequanwu@google.com>
…nversion. Change-Id: I8948e1aba598d42369d70ca1cc1168ce3841ab40 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4038509 Reviewed-by: Zequan Wu <zequanwu@google.com> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Bug: 1385147 Change-Id: I69ebfa1adbc1c2a17decf0079812c4f507e3332c Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4046961 Reviewed-by: Mike Frysinger <vapier@chromium.org>
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )