Conversation
This PR fixes an issue when ingesting image files using Cognee with the Ollama LLM provider. Previously, attempting to ingest an image resulted in the following error: `OllamaAPIAdapter.transcribe_image() missing 1 required positional argument: 'input_file' ` The issue was caused by a mismatch between the transcribe_image method signature in OllamaAPIAdapter and how it was being invoked during the ingestion pipeline. The method expected the input_file positional argument but it was not being passed correctly. This PR updates the method signature and call site to ensure the input_file parameter is passed consistently, aligning the Ollama adapter implementation with the expected interface used by the ingestion flow. After this fix, image ingestion using Ollama works correctly without raising argument errors. **Acceptance Criteria** - Image ingestion works when Ollama is configured as the LLM provider. - No missing required positional argument: 'input_file' error is raised. - The ingestion pipeline completes successfully. - The image is processed and stored correctly in Neo4j. **Verified locally on:** - Ubuntu 24.04 - Python 3.12 - Neo4j - Cognee 0.5.2 **Type of Change** - Bug fix (non-breaking change that fixes an issue) **DCO Affirmation** I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced validation for transcription output to catch missing or malformed results in audio and image processing operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )