Skip to content

[pull] main from darkreader:main #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 3 commits into from
Mar 7, 2025
Merged

[pull] main from darkreader:main #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd29f8a
Fix Slider properties
alexanderby Mar 7, 2025
96cd994
Fix for vijaysales.com (#14017)
jenny-sunshine Mar 7, 2025
a92931e
fix for bbc.co.uk (#14019)
Myshor Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/config/dynamic-theme-fixes.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3589,6 +3589,9 @@ CSS
filter: invert(90%) !important;
}

IGNORE IMAGE ANALYSIS
*

================================

bbc.com
Expand Down Expand Up @@ -30744,6 +30747,22 @@ INVERT

================================

vijaysales.com

INVERT
img[src*=".svg"]

CSS
#vscontainer-c8c1c1c302,
[style*="Background.jpg"] {
background-image: none !important;
}
.custom-hamburger .bar {
background-color: var(--darkreader-neutral-text) !important;
}

================================

vimeo.com

INVERT
Expand Down
10 changes: 6 additions & 4 deletions src/ui/controls/slider/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ interface SliderProps {
max: number;
step: number;
formatValue: (value: number) => string;
onChange: (value: number | null) => void;
onPreview?: (value: number | null) => void;
onChange: (value: number) => void;
onPreview?: (value: number) => void;
}

interface SliderStore {
Expand Down Expand Up @@ -178,8 +178,10 @@ export default function Slider(props: SliderProps) {
const refreshOnWheel = throttle(() => {
store.activeValue = stickToStep(store.wheelValue!, props.step);
store.wheelTimeoutId = setTimeout(() => {
const {onChange} = store.activeProps;
onChange(store.activeValue);
if (store.activeValue != null) {
const {onChange} = store.activeProps;
onChange(store.activeValue);
}
store.isActive = false;
store.activeValue = null;
store.wheelValue = null;
Expand Down