[pull] master from ddnet:master#102
Merged
pull[bot] merged 29 commits intoMu-L:masterfrom Sep 7, 2020
Merged
Conversation
As reported by Ravie on Discord. Tee is not drawn exactly in center.
This reverts commit b045a3d.
2763: Allow joining and inviting others via Steam friend list r=def- a=heinrich5991 Fixes #2642. 2768: Clamp kill border count r=def- a=Jupeyy fixes #2766 Appearently the center of the camera can even go outside of the kill border(like even left from it) I also notice that sometimes when zooming out, and then in again the zoom level gets negative(since the new smooth zoom)(atleast i see everything upside down for few frames) These numerical unstableness makes me sweat a bit xd Co-authored-by: heinrich5991 <heinrich5991@gmail.com> Co-authored-by: Jupeyy <jupjopjap@gmail.com>
The slow query logs are full of this: # Time: 200906 21:03:43 # User@Host: teeworlds[teeworlds] @ ger6.ddnet.tw [89.163.212.120] # Thread_id: 101540 Schema: teeworlds QC_hit: No # Query_time: 11.012166 Lock_time: 0.000000 Rows_sent: 0 Rows_examined: 0 # Rows_affected: 0 Bytes_sent: 67 SET timestamp=1599419023; LOCK TABLES record_teamrace WRITE, record_teamrace AS r WRITE; Do we really need these lock? See also https://dev.mysql.com/doc/refman/5.7/en/table-locking.html > InnoDB tables use row-level locking so that multiple sessions and > applications can read from and write to the same table simultaneously, > without making each other wait or producing inconsistent results. For > this storage engine, avoid using the LOCK TABLES statement, because it > does not offer any extra protection, but instead reduces concurrency.
2767: Don't lock SQL writes r=Zwelf a=def-
The slow query logs are full of this:
# Time: 200906 21:03:43
# User@Host: teeworlds[teeworlds] @ ger6.ddnet.tw [89.163.212.120]
# Thread_id: 101540 Schema: teeworlds QC_hit: No
# Query_time: 11.012166 Lock_time: 0.000000 Rows_sent: 0 Rows_examined: 0
# Rows_affected: 0 Bytes_sent: 67
SET timestamp=1599419023;
LOCK TABLES record_teamrace WRITE, record_teamrace AS r WRITE;
Do we really need these lock? See also
https://dev.mysql.com/doc/refman/5.7/en/table-locking.html
> InnoDB tables use row-level locking so that multiple sessions and
> applications can read from and write to the same table simultaneously,
> without making each other wait or producing inconsistent results. For
> this storage engine, avoid using the LOCK TABLES statement, because it
> does not offer any extra protection, but instead reduces concurrency.
Co-authored-by: def <dennis@felsin9.de>
2742: Add str_utf8_copy that trim broken utf8 sequence at the end. r=heinrich5991 a=TsFreddie Currently this replaces `str_copy` text input and clipboard paste in chat. Many places may need the same treatments, like steam names.  Test string: abcd今天是个好日子心想的事儿都能成今天是个好日子打开了家门咱迎春风今天是个好日子心想的事儿都能成今天是个好日子打开了家门咱迎春风今天是个好日子心想的事儿都能成今天是个好日子打 2745: Update mapres by mind r=heinrich5991 a=def- Adapted from 0.7 for new renderer. Not sure if this makes sense :D Co-authored-by: TsFreddie <tsfreddiewang@gmail.com> Co-authored-by: def <dennis@felsin9.de>
2758: Remove the rudimentary fuzzing since no one uses it anyway r=heinrich5991 a=def- 2769: Update front.png by Soreu r=heinrich5991 a=def- 2772: Dont predict camera position on spectator changed r=heinrich5991 a=BannZay No reason to predict camera position in case when we just changed spectator. But tbh I have not found a big reason to predict it at all. Co-authored-by: def <dennis@felsin9.de> Co-authored-by: Andrii <bannzay3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )