[pull] master from dolphin-emu:master#658
Merged
pull[bot] merged 37 commits intoMu-L:masterfrom Oct 13, 2024
Merged
Conversation
Dolphin already uses QStyleHints::colorScheme to detect dark mode, so this code is now redundant.
So far, Dolphin hasn't been able to run on Android devices that use a 16 KiB page size. 16 KiB page sizes are a very new Android feature that no phones have shipped with so far, so we're still compatible with the phones that exist out there, but let's get this fixed before phones start shipping with 16 KiB page sizes. Because I couldn't get Android Studio's emulator to work, I haven't been able to confirm that this change actually makes Dolphin fully compatible with devices that use a 16 KiB page size. But I have confirmed that this doesn't break anything on a regular 4 KiB page size device.
Dolphin has been using edge-to-edge rendering for a little while now, but it has required a bit of manual work. Now that edge-to-edge is becoming something expected of apps in Android 15, there's a nicer API we can use. Tested on Android 8, 11 and 13, with no changes in behavior noted.
+ a surprise `std::memcpy` in VolumeVerifier.cpp.
fix typos
Update Contributing.md
Because checking if a register is a specific immediate is a rather common operation.
No need to materialize the immediate if it is zero, we can just use WZR. Before: mov w27, #0x0 ; =0 str w27, [x29, #0x1178] After: str wzr, [x29, #0x1178]
In BTEmu.cpp, `std::mem_fn` was not necessary for the predicate to compile.
The inequality operator is automatically generated by the compiler if `operator==` is defined.
C++20: Synthesize `operator!=` From `operator==`
Remove Bloom Definitions for Skylanders Trap Team
…l-find Ranges Algorithms Modernization - Find
Ranges Algorithms Modernization - N
JitArm64: Optimize mtspr
Remove unneeded Win32 code for color scheme
Linux: Use D-Bus to inhibit screensaver
…eme-code-cleanup DolphinQt/MappingIndicator: Use Settings::IsThemeDark instead of reimplementing it.
…set minimum threshold in UI to 1% to prevent user error.
ControllerEmu: Change trigger threshold check to prevent user error.
DolphinQt: Auto hide the mapping window tab bar.
DolphinQt: Restrict size of banner image in game properties info tab.
Android: Use enableEdgeToEdge
Android: Add 16 KiB page size support
Checksum and descriptions from Redump.
Fixes LIT (https://bugs.dolphin-emu.org/issues/13635). The text does not include normals, but has lighting enabled. With the previous default of (0, 0, 0), lighting was always black (as dot(X, (0, 0, 0)) is always 0). It seems like the normal from the map in the background (0, 0, 1) is re-used. LIT also has the vertex color enabled while vertex color is not specified, the same as SMS's debug cubes; the default MissingColorValue GameINI value of solid white seems to work correctly in this case.
Cache normals in addition to binormals and tangents
Boot: don't error for NTSC IPL v1.2 of DOL-001 consoles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )