[pull] master from emscripten-core:master#205
Merged
pull[bot] merged 1 commit intoMu-L:masterfrom Oct 16, 2020
Merged
Conversation
Without this change we were using a normal Number and then `wasm-emscripten-finalize` would use that value to set an internal mutable global. This change means that users emscripten's dynamic linking now depends on the mutable globals proposal. However this is already available in all major browsers: https://webassembly.org/roadmap/ This is small step towards #12461 which can be landing in isolation without otherwise changing the ABI. Once this lands we can remove `internalizeStackPointerGlobal` from `wasm-emscripten-finalize`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )