[pull] master from flutter:master#13
Merged
pull[bot] merged 11 commits intoMu-L:masterfrom Jun 19, 2020
Merged
Conversation
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output. Fixes #53515
In google3, the Linux device is always available, and it has confused people who run the Flutter doctor and see "• Linux • Linux • linux-x64 • Linux" listed. Rename the Linux device name to "Linux desktop" and the device ID to be "linux". Make similar changes to the Windows and macOS devices for consistency. This is also consistent with the web devices. The device ID change shouldn't be break -d usage since that does a case-insensitive prefix match.
The previous call set the minimum size, not just the initial size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )