[pull] master from GerritCodeReview:master#194
Merged
pull[bot] merged 2 commits intoMu-L:masterfrom Apr 24, 2021
Merged
Conversation
This custom serializer is only needed if instance is created in one plugin, but the serialization takes place in another plugin. If the class is reachable from the same classpath loader where the event instance was instantiated, then it will work without this change. This will simplify multi-site plugin setup, that is using inter-plugin communication: o multi-site plugin, that is using events-broker o events-broker libModule, that provides BrokerApi abstraction o events-kafka plugin, that is using Apache Kafka event streaming backend and is used by events-broker's DynamicItem o events-gcloud-pubsub plugin, that is using GCloud's PubSub event streaming backend and is used by events-broker's DynamicItem o events-aws-kinesis plugin, that is using AWS's Kinesis event streaming backend and is used by events-broker's DynamicItem This change would allow us to drop EventGsonProvider fork in multi-site plugin. Change-Id: I7dc6e6a859152ee3e30a90075ddd34814720eba1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )