Merged
Conversation
Bumps [dawidd6/action-homebrew-bump-formula](https://github.com/dawidd6/action-homebrew-bump-formula) from 4 to 5. - [Release notes](https://github.com/dawidd6/action-homebrew-bump-formula/releases) - [Commits](dawidd6/action-homebrew-bump-formula@v4...v5) --- updated-dependencies: - dependency-name: dawidd6/action-homebrew-bump-formula dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The installation instructions say to make the shell init script execute the
output of `goenv init -`. That output contains this among other things:
```
export PATH="${GOENV_ROOT}/shims:${PATH}"
```
The main point of that line is to make the `go` command resolve to
`$GOENV_ROOT/shims/go` such that `goenv` has control over the default `go`.
The installation instructions later say to add this after the eval in order to
let "goenv manage GOPATH and GOROOT":
```
export PATH="$GOROOT/bin:$PATH"
export PATH="$PATH:$GOPATH/bin"
```
This effectively overrides the first line as `$GOROOT/bin` is also expected to
contain a `go` binary. However that binary is not controlled by `goenv`.
Furthermore AFAICT these two lines do not make "goenv manage GOPATH and GOROOT".
This has confused at least [one other user](#186 (comment)).
This change removes the section about GOROOT and GOPATH as I don't see why it
would belong in the goenv installation instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )