[pull] master from greenplum-db:master#46
Merged
pull[bot] merged 1 commit intoMu-L:masterfrom Jan 22, 2021
Merged
Conversation
) Jesse found this memory leak that was introduced in my previous commit df3ce784285f7d9ceccfa761fd790ece65b65cde. Adding some notes for how to detect ORCA memory leaks: Just run ORCA MDP tests should detect memory leaks inside of gporca. However, the translator code under gpopt is not tested by the MDP tests, and we by default use GPDB memory contexts in the translator. One way to detect memory leaks in the ORCA translator code is to set "optimizer_use_gpdb_allocators=0" in the gpconfig files and run the relevant queries. By doing that we instead use ORCA memory contexts and ORCA will be able to detect the memory leaks. Reported-by: Jesse Zhang <sbjesse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )