Conversation
Summary: GitHub commits: facebook/buck2-prelude@e001f8c facebook/fb303@b0b9bc9 facebook/fbthrift@24783fe facebook/folly@1880071 facebook/mvfst@936d625 0bc4c46 facebook/wangle@4686c5e facebookexperimental/edencommon@49980c8 facebookexperimental/rust-shed@7b48e32 facebookincubator/Facebook-Pixel-for-Wordpress@5a7a150 facebookincubator/fizz@4816515 https://github.com/facebookincubator/llm_orchestrator/commit/b36ead78001201e17c0ae4265b9ee1897616f391 Reviewed By: pranavcivi fbshipit-source-id: 5ecc3085d3644bbf018a3bb2462f1e6b4e12e0b0
Summary: Pull Request resolved: #583 Noticed these are showing up as stale on each regeneration Reviewed By: bigfootjon Differential Revision: D86594247 fbshipit-source-id: 2d4e361b7186d16915a0a6af99fe7812171f03b4
Summary: `StaticFileHandler` has several race conditions arising from the fact that two different threads (CpuExecutor via `::getUnsafeMutableGlobalCPUExecutor` & `EventBase` backing the HttpSession) are accessing the same memory A very simple sequence of events that could cause a crash 1. client sends `GET /index.html` 2. server begins serving bytes from the file 3. client sends malformed quic frame, causing all `HttpTransaction`s to abort and be destructed 4. reading chunk from file ends, attempt to use HttpTransaction (uaf) Reviewed By: jbeshay Differential Revision: D86682244 fbshipit-source-id: 9058e826c9df667656848cd63005924e7bb74eac
Summary: Fix edencommon build on windows, noticed it was breaking the watchman build. * fix boost local build with vs build tools 2022 17.14 update. Without this could not build boost locally. Apply patch as per boostorg/boost#914 * in buildopts.py check the 32 bit install location as non-github windows machines like my laptop end up with it installed there * fix the actual problem in edencommon `error C2039: 'wstring': is not a member of 'std'` , which was a missing <string> include Reviewed By: bigfootjon Differential Revision: D86630363 fbshipit-source-id: b4993c74cd51d326efb458a6dc461d355f8daeab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )