[pull] master from root-project:master#282
Merged
pull[bot] merged 1 commit intoMu-L:masterfrom Jun 9, 2025
Merged
Conversation
Absolute install paths can't be used for CMake targets on Windows of macOS. Commit 9bb2f50 changed the install paths of the pythonization library to be absolute paths, so that it's simple to calculate the relative paths. But this broke the installation step on Windows and macOS, and therefore has to be reverted. For the `rpath` step, the full path is obtained with `CMAKE_INSTALL_PREFIX`, and it was checked that the rpaths are still correctly computed, similar to #18969 (comment) ```txt [nix-shell:~/code/root]$ readelf -d root_build/lib/ROOT/libROOTPythonizations.so | grep RUNPATH 0x000000000000001d (RUNPATH) Library runpath: [$ORIGIN/../:/home/rembserj/code/root/root_build/lib::/nix/store/0896fyzn4l1gczab8qmlsliipq0js31x-nix-shell/lib:/nix/store/cg9s562sa33k78m63njfn1rw47dp9z0i-glibc-2.40-66/lib:/nix/store/x613hzkhr7mhv65p4l7fbmjkmc2mnhhp-gcc-15.1.0-lib/lib] [nix-shell:~/code/root]$ readelf -d root_install/lib/root/ROOT/libROOTPythonizations.so | grep RUNPATH 0x000000000000001d (RUNPATH) Library runpath: [$ORIGIN/../:/nix/store/0896fyzn4l1gczab8qmlsliipq0js31x-nix-shell/lib:/nix/store/cg9s562sa33k78m63njfn1rw47dp9z0i-glibc-2.40-66/lib:/nix/store/x613hzkhr7mhv65p4l7fbmjkmc2mnhhp-gcc-15.1.0-lib/lib] ``` Thanks @bellenot for figuring out the problem!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )