Conversation
## Summary Add PR comment workflow as a prerequisite for #19234 ## Test Plan Not yet tested. Need to merge this first.
This commit doesn't change any behavior, but makes it so `all_members` returns a `Vec<Member>` instead of `Vec<Name>`, where a `Member` contains a `Name`. This gives us an expansion point to include other data (such as the type of the `Name`).
Since we generally need (so far) to get the type information of each suggestion to figure out its boundness anyway, we might as well expose it here. Completions want to use this information to enhance the metadata on each suggestion for a more pleasant user experience. For the most part, this was pretty straight-forward. The most exciting part was in computing the types for instance attributes. I'm not 100% sure it's correct or is the best way to do it.
This makes use of the new `Type` field on `Completion` to figure out the "kind" of a `Completion`. The mapping here is perhaps a little suspect for some cases. Closes astral-sh/ty#775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )