Addition of time cluster and background cluster hits #241
+71
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NamithaChitrazee
commented
Dec 10, 2025
NamithaChitrazee
commented
- Included time cluster hits.
- Color coded the hits belonging to each background cluster better.
- Made a separate collection of hits which have been flagged as background under the AddComboHits() function. This makes it easier to identify them.
sophiemiddleton
approved these changes
Dec 10, 2025
| std::vector<const BkgClusterCollection*> bkgcluster_list = std::get<1>(bkgcluster_tuple); | ||
| // std::vector<std::string> names = std::get<0>(bkgcluster_tuple); | ||
| std::cout<<"BkgClusterCollection size = "<<bkgcluster_list.size()<<std::endl; | ||
| std::string bctitle = "BkgCluster"; |
Collaborator
There was a problem hiding this comment.
Everything looks good. I would just suggest adding some more useful information for the mouse over in this title here. Identifying that specific cluster and its features.
Contributor
Author
There was a problem hiding this comment.
Hi Sophie, thank you for the review. I'll fix this one in the next iteration because right now that title is common to all the background clusters, so I would not be able to add information about each individual cluster in this title. I'll also have to alter how I have compounded this object.
Considering, there isn't much use case for this feature right now, can we defer it to the next round of PRs.
Collaborator
There was a problem hiding this comment.
that's fine - I'll make an issue for later upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.