Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the Mu2e EventDisplay geometry handling, especially for the extracted geometry mode. The main focus is on aligning the Cosmic Ray Veto (CRV) display with the tracker geometry by applying a Z-shift based on the tracker envelope's half-length. Additionally, a new utility script for exploring GDML geometry hierarchies is added, and the example FCL configuration files are updated for consistency and improved usability.
Geometry Alignment Improvements:
CRV display alignment: The CRV visualization in extracted geometry mode now applies a Z-shift equal to the tracker envelope half-length (parsed from
tracker_v7.txt) to correctly align CRV bars, clusters, and hits with the tracker in the display. This shift is applied in both the data interface (for event data) and the geometry drawing code (for the geometry tree), ensuring visual consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]Geometry drawing code refactor: The extracted geometry drawing logic in
MainWindow.ccis updated to load tracker geometry, compute and apply the CRV Z-shift, and clarify the use of offsets for detector components. Comments are added to explain the logic and limitations regarding geometry initialization. [1] [2]New Utility Script:
gdml_hierarchy.py: A new Python script is provided for parsing GDML files and printing the parent/child hierarchy of detector volumes, with search capabilities for volume names. This aids in geometry debugging and exploration.Configuration and Example Updates:
Codebase Maintenance:
MainWindow.ccto clarify dependencies and geometry handling. [1] [2] [3]These changes collectively improve the accuracy and usability of the EventDisplay for extracted geometries, facilitate geometry debugging, and streamline configuration for end users.
Development