Skip to content

Conversation

@giro94
Copy link
Contributor

@giro94 giro94 commented May 13, 2025

Adding calorimeter branches: clusters, hits, recodigis.

Plan is to have separate branches for each struct type.
Clusters will have vector of indexes of hits.
Hits will have vector of indexes of recodigis.
Hits (digis) will have a single index of the cluster (hit) they belong to.

@giro94 giro94 marked this pull request as ready for review June 30, 2025 15:44
@giro94
Copy link
Contributor Author

giro94 commented Jun 30, 2025

Branch now properly fills calo cluster, hits, and recodigi branches.
Each branch links with both the parent and child branches with indexes.

Copy link
Collaborator

@AndrewEdmonds11 AndrewEdmonds11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Paolo! It all looks OK to me. Would you mind also doing step 8 and the first part of step 11 of these instructions to add the new branches to the ntuplehelper?

We can discuss who does what in the other steps but that can all be done in a separate PR

Copy link
Collaborator

@sophiemiddleton sophiemiddleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the code just by eye, i'd like to test it just to get a feel for the new branch

@giro94
Copy link
Contributor Author

giro94 commented Jul 1, 2025

The calo branch filling code in EventNtupleMaker is a bit ugly and 100+ rows long.
It's functional, but I will chop it up into dedicated functions later.

@giro94 giro94 requested a review from AndrewEdmonds11 July 1, 2025 17:27
Copy link
Collaborator

@AndrewEdmonds11 AndrewEdmonds11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes to ntuplehelper, Paolo. As we discussed on Slack, I will look into the bug related to that

@AndrewEdmonds11 AndrewEdmonds11 merged commit cb104b9 into Mu2e:main Jul 2, 2025
@giro94 giro94 mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants