-
Notifications
You must be signed in to change notification settings - Fork 24
Add calo branches #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calo branches #275
Conversation
|
Branch now properly fills calo cluster, hits, and recodigi branches. |
AndrewEdmonds11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, Paolo! It all looks OK to me. Would you mind also doing step 8 and the first part of step 11 of these instructions to add the new branches to the ntuplehelper?
We can discuss who does what in the other steps but that can all be done in a separate PR
sophiemiddleton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the code just by eye, i'd like to test it just to get a feel for the new branch
…from those above, i.e. hits with no clusters
|
The calo branch filling code in EventNtupleMaker is a bit ugly and 100+ rows long. |
AndrewEdmonds11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes to ntuplehelper, Paolo. As we discussed on Slack, I will look into the bug related to that
Adding calorimeter branches: clusters, hits, recodigis.
Plan is to have separate branches for each struct type.
Clusters will have vector of indexes of hits.
Hits will have vector of indexes of recodigis.
Hits (digis) will have a single index of the cluster (hit) they belong to.