V06_05_00: Final Updates #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final changes needed before tagging v06_05_00
I updated the validation script to run on up-to-date datasets:
After going through validation, I fixed the following:
There is one fcl file that fails validation (
from_mcs-extracted.fcl), which is due to a known issue (missing ProtonBunchTimMC), which Yuri and I already solved for another dataset