Skip to content

Conversation

@brownd1978
Copy link
Contributor

This includes some minor improvements:

  • use R() instead of sqrt(mag2()) for XYZVector payload.
  • removes the (non-functional) earliest and latest intersection flg, which can be extracted during analysis anyways.
  • add a flag for trkstrawinfomc that are matched to trkstrawinfo. This isn't strictly necessary but can be helpful
    -use combined KK reco sequence output in the from_digi script

I note that the rest of the config assumes the KKDeM, KKDeP split outputs, which is inconsistent with the head of Offline and the most recent MDC2020 samples. This might be a good time to reconsider having split trees. Some reworking of TrkQual calculation is also needed, which may impact how it is trained, or at least how the module loads the training.

Copy link
Collaborator

@AndrewEdmonds11 AndrewEdmonds11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dave, this looks good to me. Just a comment on TrkQual: in the default configuration we use TrkQualAll, defined as:

TrkQualAll          : @local::TrkQual
TrkQualAll.KalSeedPtrCollection : "MergeKKAll"

so there's no DeM/DeP split apparent in the configuration (I take the point that we are running the e-minus trained ANN on all tracks, which is something we need to improve). So if you want, you can rename the TrkQualDeM in this configuration to TrkQualDeCalib or something if that makes things clearer

@brownd1978
Copy link
Contributor Author

Thanks Andy, I didn't realize there was a default TrkQualDe instance, I updated the script to use that.

@AndrewEdmonds11 AndrewEdmonds11 merged commit dd8ddcf into Mu2e:main Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants