Updates to RooUtil #308
Merged
Updates to RooUtil #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AndrewEdmonds11
left a comment
AndrewEdmonds11
left a comment
There was a problem hiding this comment.
Thanks for all this, Sophie! I've made a few comments below. Could you also add some words to the README and an example macro that describes and uses the cutflow and roodisplay?
| /* | ||
| Flexible struct. Two field "cut_name" e.g t>600 ns and "passed_count" e.g. 1000 events | ||
| */ | ||
| std::string cut_name; |
Collaborator
There was a problem hiding this comment.
No need to implement in this PR but could we use the cut functions here? Than the user doesn't need to pass in the passed_count and we can get this function to do the counting too...
Collaborator
Author
|
@AndrewEdmonds11 I will target the example in the next round |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates to rooutils to make analysis easier: