Minor edits: Add a rooutil namespace and reduce some code duplication #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AndrewEdmonds11
left a comment
AndrewEdmonds11
left a comment
There was a problem hiding this comment.
Thanks for these changes, Michael! Could you also do me a favor and check that the script in EventNtuple/validation/test_rooutil_examples.sh runs through OK before I merge? It should just be a case of:
. ./EventNtuple/validation/test_rooutil_examples.sh
Thanks
Collaborator
|
Michael and I have talked offline and the examples ran fine (except for a couple that I need to debug). Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a namespace to the rooutil objects to not collide with any analysis framework code (e.g.
Track-->rooutil::Track). This creates many diffs due to adding an extra indentation in header files...I also did a couple of small edits that move some checks into separate functions to reduce some repetition.