Existing files don't satisfy precommit checks

[brownd1978]

There are many files in Offline that don't satisfy the current precommit checks. These cause commits to be rejected when changing unrelated parts of the file. I suggest systematically checking and fixing all precommit failures in one fix; maybe AI can help with tihs?

[rlcee]

Currently we do not enforce any formatting except whitespace and only on Offline. Years ago, we cleaned Offline of all whitespace errors. "muse setup" puts a git precommit check in your local area, which will enforce whitespace on "git commit". In the CI, whitespace is also checked, but I believe it does not block merge. Building with spack does not have the local precommit check, but could become part of the repo itself, which was rejected as a solution in the initial work. There are also the editor configs.
Can you be more specific in your concern? Do you think some files have escaped the checks or merged after failing checks? Or are you thinking of the lack of check in the spack build? Do you want to block merging? Do you want to add checks to other repos?
The one thing I'd like to avoid as awkward is to only apply the check in github, which continually causes PR authors to go back and adjust their PR with follow-on format commits.

[rlcee]

Just tracking down some current files, there are many violation in CMakeLists.txt, txt, xml, sql, and data files since those are not checked by design. CMakeLists is not checked because it is a "text'file". I see a few dozen cc files which fail, tracking one down to pull/1797 where the check reported whitespace errors, and the merge was made anyway.

[rlcee]

A quick look at all files in Offline finds, for code files:

DAQ/src/STMWaveformDigisFromFragments_module.cc
GeometryService/src/ProductionTargetMaker.cc
Mu2eG4/src/constructTargetPS.cc
ProductionTargetGeom/inc/ProductionTarget.hh
RecoDataProducts/inc/STMWaveformDigi.hh
STMReco/src/STMAnalyzeDigis_module.cc

[brownd1978]

Years ago, we cleaned Offline of all whitespace errors

I get errors trying to commit the existing version of the following files. There may well be others. Maybe they were force committed after the cleanup? Or maybe the precommit check has changed?

ProductionTargetGeom/inc/ProductionTarget.hh:92: trailing whitespace.
Mu2eG4/geom/ProductionTarget_Stickman_v1_0.txt:20: trailing whitespace.
Mu2eG4/src/constructTargetPS.cc:95: trailing whitespace.

Pre-commit check detected format errors, please fix and try to commit again

[rlcee]

I think my above comments concur with your experience, with the exception of "txt files are not checked". The actual rule is that txt files are not checked except geometry txt files are checked.