Skip to content

Changes in CRV geometry for Wideband simulation#1353

Merged
kutschke merged 9 commits intoMu2e:mainfrom
ehrlich-uva:WidebandSimReco3
Oct 8, 2024
Merged

Changes in CRV geometry for Wideband simulation#1353
kutschke merged 9 commits intoMu2e:mainfrom
ehrlich-uva:WidebandSimReco3

Conversation

@ehrlich-uva
Copy link
Copy Markdown
Contributor

Added trigger paddles and lead bricks for the Wideband geometry.
Changed one-sided readouts to two-sided readouts at the Wideband geometry.

These changes will not affect the regular Mu2e simulation and reconstruction (but it should still be checked with a nightly validation). The changes are only for the Wideband CRV simulation.

@kutschke Could you please add @oksuzian as a reviewer?

@FNALbuild
Copy link
Copy Markdown
Collaborator

Hi @ehrlich-uva,
You have proposed changes to files in these packages:

  • CRVResponse
  • CRVConditions
  • Mu2eG4
  • DAQ
  • CRVReco
  • GeometryService

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

The following users requested to be notified about changes to these packages:
@resnegfk

⌛ The following tests have been triggered for 0582c11: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 0582c11.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 0582c11 at 5694fbe
build (prof) Log file. Build time: 04 min 18 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 🔶 TODO (1) FIXME (4) in 7 files
clang-tidy 🔶 6 errors 349 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0582c11 after being merged into the base branch at 5694fbe.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke kutschke requested a review from oksuzian October 4, 2024 20:16
@kutschke kutschke self-assigned this Oct 4, 2024
@kutschke
Copy link
Copy Markdown
Contributor

kutschke commented Oct 4, 2024

What is the relationship between this PR and #1334 and #1226?

@ehrlich-uva
Copy link
Copy Markdown
Contributor Author

@kutschke #1226 is a geometry change for the extracted position (and affects only the extracted position). #1334 is a geometry change for Wideband (and affects only the Wideband CRV simulation).

@kutschke
Copy link
Copy Markdown
Contributor

kutschke commented Oct 4, 2024

@kutschke #1226 is a geometry change for the extracted position (and affects only the extracted position). #1334 is a geometry change for Wideband (and affects only the Wideband CRV simulation).

Can this PR be merged on it's own or does it need the other two. We don't want to merge #1226 until we make a new branch that is allowed to invalidate existing event-data files. I think that are comments to respond to on #1334 but I might be misreading it.

@ehrlich-uva
Copy link
Copy Markdown
Contributor Author

Yes, this PR 1353 can be merged on its own. But it should still be merged as the only PR on a day, so that we can see the effect it has on the nightly validation - just to make sure that it really doesn't change anything.

@kutschke
Copy link
Copy Markdown
Contributor

kutschke commented Oct 4, 2024

Yes, this PR 1353 can be merged on its own. But it should still be merged as the only PR on a day, so that we can see the effect it has on the nightly validation - just to make sure that it really doesn't change anything.

Thanks - I will watch for Yuri's approval and find an appropriate day to merge.

@ehrlich-uva
Copy link
Copy Markdown
Contributor Author

image
Stack of 4 CRV modules with 2 trigger paddles and a layer of lead bricks.

@kutschke
Copy link
Copy Markdown
Contributor

kutschke commented Oct 7, 2024

@FNALbuild run build test

@ehrlich-uva are you finished with the planned commits to this PR?

@FNALbuild
Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 01ad888: build (Build queue is empty)

@FNALbuild
Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 01ad888.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 01ad888 at 3ba3b5b
build (prof) Log file. Build time: 04 min 14 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 🔶 TODO (0) FIXME (4) in 7 files
clang-tidy 🔶 6 errors 347 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 01ad888 after being merged into the base branch at 3ba3b5b.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@ehrlich-uva
Copy link
Copy Markdown
Contributor Author

@kutschke Yes, I'm done.

@kutschke kutschke merged commit bab09da into Mu2e:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants