Skip to content

Conversation

@giro94
Copy link
Collaborator

@giro94 giro94 commented Jan 29, 2026

Adding NDF column for separate Chi2/ndf information

@giro94 giro94 requested review from brownd1978 and rlcee January 29, 2026 16:11
@FNALbuild
Copy link
Collaborator

Hi @giro94,
You have proposed changes to files in these packages:

  • DbTables

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for c75ef9d: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at c75ef9d.

Test Result Details
test with Command did not list any other PRs to include
merge Merged c75ef9d at cdbcae2
build (prof) Log file. Build time: 04 min 35 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at c75ef9d after being merged into the base branch at cdbcae2.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@rlcee rlcee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pulled this code down and used it to test against the actual database. I'm coordinating with Paolo in slack. I think this extension will work fine. This is an archive table so there are no constraints on reproducibility, but I think we could possibly also extend a production reco table and maintain strict reproducibility, if needed.
This table is not high-use, so it is not critical, but technically, I should modify the production database before this is merged. I can post a note here when it is ready.

@oksuzian oksuzian merged commit 10cc8f7 into Mu2e:main Jan 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants