-
Notifications
You must be signed in to change notification settings - Fork 98
remove BTrk #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove BTrk #1708
Conversation
… which is used for BTrkData/inc/Doublet.hh
…le.cc, commented out TrkPatRec/src/KalFinalFitDiag_tool.cc and TrkPatRec/src/KalFinalFit_module.cc
…doublet.hh in CalTimePeakFinder_module, removed MergeHelixFinder_module, removed DoubletAmbigResolver
…rkUtilities and BTrk includse in Trkutilities
…dule.hh, and got rid of unused includes in CalPatRec/inc/CalHelixFinder_module.hh, which only needs HelixTraj.hh
…er_module.cc and CalPatRec/src/ObjectDumpUtils.cc
…emove BTrk/TrkBase/HelixTraj.hh includes
…TrackerConditions, and RecoDataProducts
merge current Offline main
…h removing Mu2eBTrk from CMakeLists:
…ching packages. Refactor TrkParticle
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for 4c5637c: build (Build queue - API unavailable) |
|
☔ The build tests failed for 4c5637c.
N.B. These results were obtained from a build of this Pull Request at 4c5637c after being merged into the base branch at 4f1ca06. For more information, please check the job page here. |
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for 6aa47d8: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 6aa47d8.
N.B. These results were obtained from a build of this Pull Request at 6aa47d8 after being merged into the base branch at 4f1ca06. For more information, please check the job page here. |
rlcee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have spot checked several files and taken a closer look at a few things that I am familiar with, like Proditions. I don't see anything of any particular concern. Congrats on this big step.
This PR removes BTrk and all references to its dependencies, in particular KalRep, from the Mu2e codebase.
A few deeply-embedded references to low-level BTrk classes, mostly in CalPatRec, have been left. To satisfy those dependeices, truncated versions of a handful of BTrk classes were moved to the new Mu2e package BTrkLegacy. Those are all marked as deprecated, and all uses of them should be either retired or refactored to use modern equivalents eventually.
The BTrkData, Mu2eBTrk, TrkExt, TrackCaloMatch directories have been removed, as they depended in detailed ways on BTrk structures in their implementation, and their functionality has been replaced with superior codes using KinKal track.
The TrackSummary* classes have been stripped of their BTrk dependencies, which renders them useless. I believe these have all been superseded by other analysis classes, these entire directories should probably be removed.
TEveEventDisplay had many BTrk dependencies: those have been stripped out to get the code to compile, but not tested. This package has been replaced by EventDisplay and should be removed.
Proditions services tied to BTrk (mu2eDetector and mu2eMaterial) have been disabled, but may still have some residue.
Both spack and muse builds have been tested. The link dependence on BTrk in the spack build was removed in my test, but changes outside Offline are required to make that permanent. The scons build still pulls in BTrk libraries, that needs to be fixed in another repo.
Followup changes are also required in EventNtuple and EventDisplay, those are submitted in separate PRs. Other repos (stntuple? tutorial?) may also require updates. It's also possible there are BTrk references in Offline in non-standard locations.
There is followup work also to remove BTrk-related data members in KalSegment, and maybe other classes.
These changes have been shown to produce functional output running reconstruction, primary generation, and digitization, using the slack build.
This PR is largely the work of Jason Guo, an undergraduate student at UCB.