Add empty collection guard in TimeAndPhiClusterFinder::findTimePeaks#1731
Merged
Add empty collection guard in TimeAndPhiClusterFinder::findTimePeaks#1731
Conversation
Collaborator
|
☀️ The build tests passed at 99412e9.
N.B. These results were obtained from a build of this Pull Request at 99412e9 after being merged into the base branch at db6161d. For more information, please check the job page here. |
rlcee
approved these changes
Feb 15, 2026
Collaborator
rlcee
left a comment
There was a problem hiding this comment.
Given the following line, this is obviously necessary, but I can't comment whether chGood can legitimately be empty at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.