Skip to content

APR cleanup#1830

Merged
oksuzian merged 1 commit into
Mu2e:mainfrom
michaelmackenzie:APRCleanup
May 15, 2026
Merged

APR cleanup#1830
oksuzian merged 1 commit into
Mu2e:mainfrom
michaelmackenzie:APRCleanup

Conversation

@michaelmackenzie

Copy link
Copy Markdown
Contributor

Minor changes to APR, mostly to add the nhits < 3 check which would lead to an unsigned underflow issue. This of course shouldn't happen with our time clustering algorithms, but we cover it anyway. I also happened to move a calculation such that it's only done if needed, but this shouldn't be impactful.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

  • CalPatRec

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 0615961: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 0615961.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 0615961 at 95f0a83
build (prof) Log file. Build time: 04 min 20 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 3 errors 104 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0615961 after being merged into the base branch at 95f0a83.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian oksuzian merged commit 23fc715 into Mu2e:main May 15, 2026
14 checks passed
@michaelmackenzie michaelmackenzie deleted the APRCleanup branch May 15, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants