Added new reco table for Calorimeter baselines and new archive table …

[giro94]

…for time calibration with cosmics

[FNALbuild]

Hi @giro94,
You have proposed changes to files in these packages:

• DbTables

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for a5f5574: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at a5f5574.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged a5f5574 at 27e994d
build (prof)	✅	Log file. Build time: 04 min 15 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 2 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at a5f5574 after being merged into the base branch at 27e994d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[giro94]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for 2c0ebf2: build (Build queue - API unavailable)

[FNALbuild]

☔ The build is failing at 2c0ebf2.

scons: *** [build/al9-prof-e29-p101/Offline/tmp/DbTables/src/DbTableFactory.os] Error 1

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 2c0ebf2 at 27e994d
build (prof)	❌	Log file.
ceSimReco	〰️	Log file.
g4test_03MT	〰️	Log file.
transportOnly	〰️	Log file.
POT	〰️	Log file.
g4study	〰️	Log file.
cosmicSimReco	〰️	Log file.
cosmicOffSpill	〰️	Log file.
ceSteps	〰️	Log file.
ceDigi	〰️	Log file.
muDauSteps	〰️	Log file.
ceMix	〰️	Log file.
rootOverlaps	〰️	Log file.
g4surfaceCheck	〰️	Log file.
trigger	❗	Log file.
check_cmake	〰️	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	➡️	1 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 2c0ebf2 after being merged into the base branch at 27e994d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[giro94]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for b091f88: build (Build queue - API unavailable)

[giro94]

@rlcee

CalBaselines will be a reco (production) table that gets information from the run_info dump (Cat 3 table)
CalCosmicTimeCalib will be an archive table for producing time calibrations with cosmic rays. Not sure if I will ad an adhoc Info table later on

[FNALbuild]

☀️ The build tests passed at b091f88.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged b091f88 at 27e994d
build (prof)	✅	Log file. Build time: 08 min 42 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 3 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at b091f88 after being merged into the base branch at 27e994d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[rlcee]

Looks good, I think a couple of typos

[giro94]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for 23f0df0: build (Build queue - API unavailable)

[FNALbuild]

☔ The build is failing at 23f0df0.

scons: *** [build/al9-prof-e29-p101/Offline/tmp/DbTables/src/DbTableFactory.os] Error 1
scons: *** [build/al9-prof-e29-p101/Offline/tmp/CaloConditions/src/CalCalib.os] Error 1
scons: *** [build/al9-prof-e29-p101/Offline/tmp/CaloConditions/src/CalCalibMaker.os] Error 1
scons: *** [build/al9-prof-e29-p101/Offline/tmp/ProditionsService/src/ProditionsService.os] Error 1
scons: *** [build/al9-prof-e29-p101/Offline/tmp/CaloReco/src/CaloRecoDigiMaker_module.os] Error 1

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 23f0df0 at 4bda08c
build (prof)	❌	Log file.
ceSimReco	〰️	Log file.
g4test_03MT	〰️	Log file.
transportOnly	〰️	Log file.
POT	〰️	Log file.
g4study	〰️	Log file.
cosmicSimReco	〰️	Log file.
cosmicOffSpill	〰️	Log file.
ceSteps	〰️	Log file.
ceDigi	〰️	Log file.
muDauSteps	〰️	Log file.
ceMix	〰️	Log file.
rootOverlaps	〰️	Log file.
g4surfaceCheck	〰️	Log file.
trigger	❗	Log file.
check_cmake	〰️	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 12 files
clang-tidy	➡️	4 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 23f0df0 after being merged into the base branch at 4bda08c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[giro94]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for 4c37908: build (Build queue - API unavailable)

[FNALbuild]

☀️ The build tests passed at 4c37908.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 4c37908 at 4bda08c
build (prof)	✅	Log file. Build time: 04 min 16 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 12 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 4c37908 after being merged into the base branch at 4bda08c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[rlcee]

Sorry, I thought I had signed off..

[giro94]

Who can merge this? @brownd1978 @oksuzian ?

[oksuzian]

🐛 Issue found — CalBaselines missing #include "CaloConst.hh"

CalBaselines.hh references CaloConst::_nChannelDB (line 42 and 48) but never includes CaloConst.hh:

    virtual std::size_t nrowFix() const override { return CaloConst::_nChannelDB; };
...
    if (index >= CaloConst::_nChannelDB || index != _rows.size()) {

It only includes CaloSiPMId.hh, which forward-uses CaloConst via its include of CaloConst.hh — so it compiles today transitively. This is fragile: it relies on CaloSiPMId.hh continuing to pull in CaloConst.hh. The sibling CalCosmicTimeCalib.hh has the same latent gap. Recommendation: add #include "Offline/DataProducts/inc/CaloConst.hh" to both new headers (every other Cal table that uses _nChannelDB should too, but the two new files are the ones to fix here).

⚠️ Unaddressed reviewer comments (still open on the diff)

@rlcee requested changes that don't appear fully applied in the head commit:

• double vs float: ctor takes double T0, ErrT0, chisq but members are float — narrowing on every construction. Reviewer flagged "these should be float?" → make the ctor params float (or members double) for consistency.
• Dead code: leftover //std::map<int,std::size_t> _chanIndex; comment ("could remove") — still present.
• The cal.cosmictimecalib table-name typo was fixed. 👍

Minor

• CalBaselines / CalCosmicTimeCalib redeclare nrowFix() as virtual + override (redundant virtual), matching existing style — harmless.

[giro94]

@FNALbuild run build test

[FNALbuild]

⌛ The following tests have been triggered for fcfef3f: build (Build queue - API unavailable)

[FNALbuild]

☀️ The build tests passed at fcfef3f.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged fcfef3f at 4bda08c
build (prof)	✅	Log file. Build time: 04 min 15 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 15 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at fcfef3f after being merged into the base branch at 4bda08c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.