Update to run1_a#469
Merged
Merged
Conversation
Collaborator
|
Hi @brownd1978,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for d0d5b54: build (Build queue - API unavailable) |
Collaborator
|
☔ The build tests failed for d0d5b54.
N.B. These results were obtained from a build of this Pull Request at d0d5b54 after being merged into the base branch at 9f964b4. For more information, please check the job page here. |
Collaborator
|
Why change potSim to common from common_current? I understand they point the same place now, but this choice was intentional, as I recall. |
Collaborator
Author
|
They point to exactly the same thing. I don't see the need for a common,
common_current division anymore, we now need explicit variants (MDC2020,
etc).
The next cleanup will replace these with 1 file.
…On Wed, Oct 15, 2025 at 12:29 PM Ray Culbertson ***@***.***> wrote:
*rlcee* left a comment (Mu2e/Production#469)
<#469 (comment)>
Why change potSim to common from common_current? I understand they point
the same place now, but this choice was intentional, as I recall.
—
Reply to this email directly, view it on GitHub
<#469 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAH575ECKBDSHCMWXBP6TL3X2OAVAVCNFSM6AAAAACJGCRYE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBXHE2TONRYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
|
rlcee
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change CI scripts to be compatible with run1_a geometry