Skip to content

Conversation

@ehrlich-uva
Copy link
Contributor

This PR does not change simulation and reconstruction.
It requires Offline PR 1644.

@FNALbuild
Copy link
Collaborator

Hi @ehrlich-uva,
You have proposed changes to files in these packages:

  • Pass1

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 4847212: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 4847212.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 4847212 at 1e15fc2
build (prof) Log file. Build time: 04 min 45 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 4847212 after being merged into the base branch at 1e15fc2.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@corrodis corrodis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are mainly root macros I don't have any concerns and I think we can merge this in, however there are a few things I don't understand that I just want to bring up for consideration:

  • why are the root files openeds in "update" mode? If I run a root macro to write some calibration values to a text file, I would kind of assume the input root files are not modified? (I think they are not but maybe better not open them with "update"?)
  • I'm really not in the loop about this, but to first order, to me, it is not clear why the extraction of calibration constants is done in root macros and not in art modules? My, maybe naive, assumption would be that art modules might make it easier to eventually automate the full calibration chain?

@brownd1978 brownd1978 requested a review from corrodis November 25, 2025 17:38
@brownd1978
Copy link
Collaborator

@corrodis I added you to triage for this repo, could you please re-approve? then I can merge.

@ehrlich-uva
Copy link
Contributor Author

The fcl files for creating the pedestal histograms and calibration histograms are regular art jobs with art modules. They run parallel for each subrun to save time. The resulting Root files (with pedestal and calibration histograms from each subrun) are merged ($ROOTSYS/bin/hadd) into a single Root file. The .C scripts use these single Root files to fit the merged histograms. The fit is a simple task that only takes seconds, so I though that a simple Root macro is sufficient. The fit results are added to the histograms. That's why I'm opening the Root files in update mode. If you like, I can just create a new output file.

@brownd1978 brownd1978 merged commit 408fdd7 into Mu2e:main Nov 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants