Add muon stop output for COL5 muon stops#538
Conversation
|
Hi @michaelmackenzie,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 0a19c2f: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 0a19c2f.
N.B. These results were obtained from a build of this Pull Request at 0a19c2f after being merged into the base branch at ed044a2. For more information, please check the job page here. |
PR #538 Review — Add muon stop output for COL5 muon stopsSummaryAuthor: @michaelmackenzie · Branch: Adds a new CI: ✅ All FNALbuild checks passed (build #617). Core changes
🔴 Issues found1. Dead code:
|
| Check | Status |
|---|---|
| Builds & functional tests (FNALbuild #617) | ✅ all green |
| clang‑tidy / FIXME‑TODO | ✅ clean |
| Reviews | mergeable_state: blocked) |
| Offline dep PR #1817 | COL5Poly material name is defined there |
| Dead producer (#1 above) | 🔴 should be resolved |
Recommendation: request changes to remove or wire up stoppedPolyMuonDaughters, clarify the prescale rationale, and confirm Offline#1817 lands first.
Want me to
- Draft a review comment on the PR with the dead‑code finding and prescale question?
- Pull Give COL5 material a name, without any change to the composition Offline#1817 to verify the
COL5Polymaterial name is actually introduced there? - Search the Production repo for other usages of
stoppedMuonDaughtersto confirm whetherstoppedPolyMuonDaughterswas intended for an analogous spot? - Check related fcl files (
NeutralsResampler.fcl, etc.) to see if poly‑stop wiring is also needed there?
These stops are important for RMC analyses, as the photons produced can reach the calorimeter. This relies on PR Mu2e/Offline#1817 which creates a unique name for the COL5 material in order to select these stops.