Skip to content

fix(chu): 添加 Umiguri 新版本头部标签到静默忽略列表#4

Merged
Starrah merged 2 commits into
MuNET-OSS:masterfrom
Applesaber:fix/ugc-unknown-header-tags
May 28, 2026
Merged

fix(chu): 添加 Umiguri 新版本头部标签到静默忽略列表#4
Starrah merged 2 commits into
MuNET-OSS:masterfrom
Applesaber:fix/ugc-unknown-header-tags

Conversation

@Applesaber
Copy link
Copy Markdown
Contributor

@Applesaber Applesaber commented May 28, 2026

添加以下 Umiguri 新版本使用的头部标签到 UgcParser 的静默忽略列表:

  • @MAINBPM\ — 主 BPM 显示值
  • @usetil\ — TIL 切换指令
  • @ENDHEAD\ — 头部结束标记
  • @BGSCENE\ — 背景场景
  • @FLDSCENE\ — 地面场景
  • @RLDATE\ — 发布日期
  • @cmt\ — 注释

这些标签是 Umiguri 的元数据/渲染相关标签,对转谱逻辑不影响,之前会触发「未知头部标签」的 Info 级别警告。

Summary by Sourcery

错误修复:

  • 防止 Umiguri 元数据和与渲染相关的头部标签在 UgcParser 中产生多余的信息级 “unknown header” 警告。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Prevent new Umiguri metadata and rendering-related header tags from generating spurious info-level "unknown header" warnings in UgcParser.

添加 @MAINBPM @usetil @ENDHEAD @BGSCENE @FLDSCENE @RLDATE @cmt
这些标签是 Umiguri 新版本使用的元数据/渲染相关标签,对转谱不影响
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 28, 2026

审阅者指南(在小型 PR 上折叠)

审阅者指南

向 UgcParser 的“静默忽略”头标签列表中添加了若干新的 Umiguri 专用头标签,这样它们将不再产生“未知头标签”的 info 级别提示,因为它们仅用于元数据/渲染,不影响谱面转换逻辑。

文件级变更

变更 详情 文件
扩展 Chu UGC 头部解析器的静默忽略列表,加入新的 Umiguri 元数据/渲染标签,使其被解析为 no-op,而不是生成 info 级别警告。
  • 在负责将已知外观(cosmetic)头标签视为忽略项的 switch case 分支中添加 @MAINBPM、@usetil 和 @ENDHEAD
  • 在同一个忽略标签的 case 代码块中添加 @BGSCENE、@FLDSCENE、@RLDATE 和 @cmt,以避免这些新 Umiguri 版本出现未知头标签警告
parser/chu/UgcParser.cs

提示与命令

与 Sourcery 交互

  • 触发新的审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 在某条审阅评论下回复,让 Sourcery 从该评论创建 issue。你也可以回复 @sourcery-ai issue,从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在该位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 撤销所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可撤销所有现有的 Sourcery 审阅。尤其适用于你想从头开始新的审阅——别忘了评论 @sourcery-ai review 来触发新一轮审阅!

自定义你的体验

访问你的控制面板 以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅指令。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds several new Umiguri-specific header tags to the UgcParser’s silently-ignored header list so they no longer emit "unknown header tag" info-level alerts, as they are metadata/rendering-only and do not affect chart conversion logic.

File-Level Changes

Change Details Files
Extend the Chu UGC header parser’s silent-ignore list with new Umiguri metadata/rendering tags so they are parsed as no-ops instead of generating info-level warnings.
  • Add @MAINBPM, @usetil, and @ENDHEAD to the switch case branch that treats known cosmetic header tags as ignored
  • Add @BGSCENE, @FLDSCENE, @RLDATE, and @cmt to the same ignored-tag case block to prevent unknown-header alerts for these new Umiguri versions
parser/chu/UgcParser.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several UGC header tags to the silent ignore list in UgcParser.cs. However, adding @ENDHEAD to this list introduces a potential bug where the parser fails to transition out of the header state if the tag contains trailing whitespace, leading to empty note lists. It is recommended to handle @ENDHEAD using robust tag extraction logic in the main parse loop instead.

Comment thread parser/chu/UgcParser.cs Outdated
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨——我已经审阅了你的修改,一切看起来都很棒!


Sourcery 对开源项目是免费的——如果你喜欢我们的评审,请考虑分享给更多人 ✨
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进今后的评审。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@Starrah Starrah merged commit 6155c45 into MuNET-OSS:master May 28, 2026
3 checks passed
@Applesaber Applesaber deleted the fix/ugc-unknown-header-tags branch May 28, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants