Skip to content

Try fixing public doc read access #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckgrayduck merged 1 commit into from
Apr 30, 2026
Merged

Try fixing public doc read access #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions documentcloud/common/environment/aws/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ def open(self, file_name, mode="rb", content_type=None, access=None):
writeable_kwargs["ACL"] = ACLS[access]
if writeable_kwargs:
# Guard against no writeable kwargs provided
transport_params["client_kwargs"] = {
"S3.Client.create_multipart_upload": writeable_kwargs
}
# smart_open 7.x passes client_kwargs
# directly to put_object/create_multipart_upload
transport_params["client_kwargs"] = writeable_kwargs
return smart_open.open(
f"s3://{file_name}", mode, transport_params=transport_params
)
Expand Down
6 changes: 3 additions & 3 deletions tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ def format(c):
cmd="black documentcloud --exclude migrations && "
"black config/urls.py && "
"black config/settings && "
"isort -rc documentcloud && "
"isort -rc config/urls.py && "
"isort -rc config/settings"
"isort documentcloud && "
"isort config/urls.py && "
"isort config/settings"
)
)

Expand Down
Loading