Skip to content

Bstats#49

Merged
OllieMartin merged 3 commits intodatabasefrom
bstats
Apr 6, 2019
Merged

Bstats#49
OllieMartin merged 3 commits intodatabasefrom
bstats

Conversation

@OllieMartin
Copy link
Copy Markdown
Contributor

Please do not submit major pull requests without first discussing them with me. Contact me on Discord (https://discord.gg/PVreERC) or otherwise.

Description

What, briefly, is the purpose of this pull request?

Is this pull request related to an issue with the plugin?

What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]

Changes

What currently existing parts of the plugin are affected by this pull request

What new features are added to the plugin by this pull request

Standards

Does this pull request adhere to basic Java coding standards?

Is the pull request suitably javadoc'd? (E.g. Have you written detailed javadoc on all public methods)

Does this pull request seem to stay true to the style used so far in the MultiChat code.

This is not to say you MUST code exactly as I do. But programs should have consistency, both in the actual code, and in documentation.
Some specific examples of 'style' choices in the MultiChat code are as follows:

Curly braces should in general NOT be opened on their own line.

E.g.

if ( ... ) {
}

NOT

if ( ... )
{
}

Comments should be written where possible and should have a space after the //

E.g.

// This is a comment

NOT

//This is a comment

@OllieMartin OllieMartin merged commit 9116254 into database Apr 6, 2019
@OllieMartin OllieMartin deleted the bstats branch February 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant