Bstats#49
Merged
OllieMartin merged 3 commits intodatabasefrom Apr 6, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not submit major pull requests without first discussing them with me. Contact me on Discord (https://discord.gg/PVreERC) or otherwise.
Description
What, briefly, is the purpose of this pull request?
Is this pull request related to an issue with the plugin?
What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]
Changes
What currently existing parts of the plugin are affected by this pull request
What new features are added to the plugin by this pull request
Standards
Does this pull request adhere to basic Java coding standards?
Is the pull request suitably javadoc'd? (E.g. Have you written detailed javadoc on all public methods)
Does this pull request seem to stay true to the style used so far in the MultiChat code.
This is not to say you MUST code exactly as I do. But programs should have consistency, both in the actual code, and in documentation.
Some specific examples of 'style' choices in the MultiChat code are as follows:
Curly braces should in general NOT be opened on their own line.
E.g.
if ( ... ) { }NOT
if ( ... ) { }Comments should be written where possible and should have a space after the //
E.g.
// This is a commentNOT
//This is a comment