Add SPNEGO support 664#683
Merged
Mastermind-U merged 7 commits intomainfrom Aug 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds SPNEGO (Security Provider Negotiation Protocol) support to the LDAP protocol implementation. SPNEGO provides a negotiation mechanism that typically wraps Kerberos authentication, allowing for more flexible GSS-API authentication flows.
- Implements
SaslSPNEGOAuthenticationclass that extends the existing GSSAPI authentication - Updates the supported SASL mechanisms list to include "GSS-SPNEGO"
- Modifies security context initialization to support multiple authentication mechanisms
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
app/ldap_protocol/ldap_requests/bind_methods/sasl_spnego.py |
New SPNEGO authentication implementation inheriting from GSSAPI |
app/ldap_protocol/ldap_requests/bind_methods/base.py |
Adds GSS_SPNEGO to the SASLMethod enum |
app/ldap_protocol/ldap_requests/bind_methods/__init__.py |
Registers the new SPNEGO authentication class |
app/ldap_protocol/ldap_requests/bind_methods/sasl_gssapi.py |
Removes Kerberos-specific mechanism restriction to support SPNEGO negotiation |
app/ldap_protocol/ldap_requests/bind.py |
Updates bind handling to include SPNEGO server credentials in response |
app/ldap_protocol/ldap_requests/search.py |
Adds GSS-SPNEGO to supported SASL mechanisms in root DSE |
tests/test_ldap/test_bind.py |
Adds comprehensive tests for SPNEGO authentication flows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.