Skip to content

Add SPNEGO support 664#683

Merged
Mastermind-U merged 7 commits intomainfrom
add_spnego_support
Aug 20, 2025
Merged

Add SPNEGO support 664#683
Mastermind-U merged 7 commits intomainfrom
add_spnego_support

Conversation

@Naksen
Copy link
Copy Markdown
Collaborator

@Naksen Naksen commented Aug 19, 2025

No description provided.

@Naksen Naksen changed the title Add SPNEGO support Add SPNEGO support 664 Aug 19, 2025
@Naksen Naksen requested a review from Copilot August 20, 2025 12:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds SPNEGO (Security Provider Negotiation Protocol) support to the LDAP protocol implementation. SPNEGO provides a negotiation mechanism that typically wraps Kerberos authentication, allowing for more flexible GSS-API authentication flows.

  • Implements SaslSPNEGOAuthentication class that extends the existing GSSAPI authentication
  • Updates the supported SASL mechanisms list to include "GSS-SPNEGO"
  • Modifies security context initialization to support multiple authentication mechanisms

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/ldap_protocol/ldap_requests/bind_methods/sasl_spnego.py New SPNEGO authentication implementation inheriting from GSSAPI
app/ldap_protocol/ldap_requests/bind_methods/base.py Adds GSS_SPNEGO to the SASLMethod enum
app/ldap_protocol/ldap_requests/bind_methods/__init__.py Registers the new SPNEGO authentication class
app/ldap_protocol/ldap_requests/bind_methods/sasl_gssapi.py Removes Kerberos-specific mechanism restriction to support SPNEGO negotiation
app/ldap_protocol/ldap_requests/bind.py Updates bind handling to include SPNEGO server credentials in response
app/ldap_protocol/ldap_requests/search.py Adds GSS-SPNEGO to supported SASL mechanisms in root DSE
tests/test_ldap/test_bind.py Adds comprehensive tests for SPNEGO authentication flows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

@Mastermind-U Mastermind-U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@Mastermind-U Mastermind-U merged commit 866d916 into main Aug 20, 2025
4 checks passed
@Mastermind-U Mastermind-U deleted the add_spnego_support branch August 20, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants