Skip to content

Conversation

@iyashnov
Copy link
Collaborator

No description provided.

@rimu-stack rimu-stack requested a review from Copilot October 22, 2025 12:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the persistence of DHCP subnet data by migrating configuration storage from host-mounted directories to Docker named volumes and adding explicit configuration writes after DHCP operations.

Key changes:

  • Replaced host-mounted ./.dhcp directory with a named Docker volume dhcp for persistent configuration storage
  • Added write_config() calls after all DHCP create/update/delete operations to ensure changes are persisted
  • Moved initial DHCP configuration from host directory into the Docker image build

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docker-compose.yml Replaced host mount ./.dhcp with named volume dhcp for kea_dhcp4 service; updated volume declarations
.package/docker-compose.yml Applied same volume changes as main docker-compose.yml for packaged deployment
.docker/kea.Dockerfile Added initial kea-dhcp4.conf configuration to be baked into the Docker image
.dhcp/kea-dhcp4.conf Removed static configuration file (now built into image)
app/ldap_protocol/dhcp/base.py Added abstract method write_config() to AbstractDHCPAPIRepository
app/ldap_protocol/dhcp/kea_dhcp_manager.py Added write_config() calls after subnet and reservation operations
app/ldap_protocol/dhcp/stub.py Implemented stub version of write_config() method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rimu-stack rimu-stack merged commit 0bb14f0 into main Oct 22, 2025
4 checks passed
@rimu-stack rimu-stack deleted the fix_dhcp_subnet_save branch October 22, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants