Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an automated one-shot migration path to import BIND9 zones/records into PowerDNS, exposed as a new CLI entrypoint and runnable via a dedicated Docker Compose service.
Changes:
- Added
BindToPDNSMigrationManagerto parse BIND config/zone files and create zones/records in PowerDNS. - Added
--migrate_dnsentrypoint wiring inmultidirectory.pyand DI provider wiring inioc.py. - Added a
dns_migrationservice to.package/docker-compose.ymlto run the migration container after DB migrations and PowerDNS startup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
app/multidirectory.py |
Adds a new --migrate_dns entrypoint/factory to run the migration manager. |
app/ldap_protocol/dns/managers/bind_to_pdns_migrations_manager.py |
Implements the BIND→PowerDNS migration logic (config parsing, zone parsing, record creation, marker files). |
app/ioc.py |
Registers a DI provider to construct BindToPDNSMigrationManager with PowerDNS clients/settings. |
.package/docker-compose.yml |
Adds a production/package compose service to execute the DNS migration container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/ldap_protocol/dns/managers/bind_to_pdns_migrations_manager.py
Outdated
Show resolved
Hide resolved
Naksen
requested changes
Mar 4, 2026
Naksen
approved these changes
Mar 4, 2026
Naksen
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задача: 1048
Добавлена автоматическая миграция с Bind9 на PowerDNS. Происходит проверка наличия файлов зоны и файлов-маркеров. Если файл-маркер отсутствует и присутствую файлы зоны, то происходит парс файлов бинда и создание всех найденых зон в PowerDNS.
Добавлен менеджер миграции
Добавлен контейнер только в продовый компоуз