Downloading FTB packs does not apply the icon

[Rafii2198]

Operating System

Windows, Linux

Description of bug

Whenever you download FTB pack, it does not apply the icon of the pack but downloads it. For example Curseforge modpacks' icons are applied automatically.
The New Instance menu shows the icon of the pack (In top left corner), and making it not apply my confuse people, and they might not know it is downloaded so they'll search for their own.

Steps to reproduce

• Just download any modpack from FTB.
• You will see that it will use default icon.
• The icon that should be applied will be downloaded and appear normally in icons menu.

Suspected cause

No response

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

[jamierocks]

I can't reproduce this, works fine for me.

[Rafii2198]

Hmm... I asked my friends and something weird happened. Initially I wanted to say that it is happening on Development channel, but as soon as I changed to Stable it began to work properly, even when changing back to Development... So basically it is fixed, but it has to be done manually. Also 4 people getting this bug is surely not a coincidence.

[Rafii2198]

It is next day, I turned on my PC and downloaded FTB University and it stopped working again... I have no idea what's going on. I am still on Development channel btw.

[tort-oise]

I'm on development, it works totally fine for me, installing FTB Endeavour. Can you specify exactly what pack you're installing when the icons disappear?
Or, perhaps, check your icons folder if the icon was downloaded, but not actually applied by accident?

[Rafii2198]

Ok, here are some of my steps I did now and I am more confused:

1. I added FTB Revelations instance, it applied the icon,
2. I added normal vanilla instance,
3. I added FTB Infinity 1.7 and it did not applied the icon,
4. I added another vanilla instance, this time I changed the icon while creating,
5. I added FTB Continuum and FTB Omnia instances, both icons where applied.

I created vanilla instanced because I thought it maybe has something to do with creating multiple instances

It seems that it works sometimes and sometimes it doesn't. I just also downloaded again Academy 1.16 and University 1.16 and it did not apply the icons again. These 2 modpacks started this issue.
And all of the icons are downloaded but just not applied

[Rafii2198]

Looking at this screenshot I got enlightened. As you can see all the modpacks that have not applied the icon have dot in the name. Like Academy 1.16, Infinity Evolved 1.7, I just tried Pyramid Reborn 3.0 and it also didn't apply. Even the names of these icon have everything until the dot like FTB University 1 instead of FTB Univeristy 1.16. Pyramid modpack icon name is FTB Pyramid Reborn 3 but should be 3.0. But every modpack that does not have the dot in the name work perfectly, like FTB Continuum or FTB Cotton that I just tested.

[tort-oise]

Hey, that's actually a really good point.
I tried it, downloading FTB Infinity Evolved 1.7. I'm getting the same issue.

@jamierocks , reproduction fixed. The cause was the use of dots in the name of the modpack.
I think file extensions are hindering us here, as if I check my icons folder, the file extension is changed a .7 file, as displayed here which is confusing MultiMC, and it doesn't apply the icon because it expects an .png or .jpeg file, and the name matching the original input.
I'm not sure if there's a possible fix for that. Maybe forcing a .png or .jpeg extension to downloaded files. Then again, it isn't that big of an issue, as you can just apply it from your icons folder.

[Rafii2198]

I don't know much about programing such stuff, but wouldn't it be easier to just remove dots from file names so it would be FTB Infinity Evolved 17? or changing them to say dot, like FTB Infinity Evolved 1dot7?

I remember someone's quote that goes something like People are dumb, and developers should prepare for that. basically saying that people don't know about such small bugs and won't fix them manually ;) But it is just an icon so it shouldn't be a big priority.

[tort-oise]

I don't know how to write stuff for MultiMC, but that sounds like a great idea. Again, no idea how to implement it though.

[phit]

related to #3702
the whole filename as icon id is rather fragile right now

[Rafii2198]

I also want to add that FTB modpacks are the only ones that have this issue. It is the only modpack type that saves icons names with the dots, FTB Legacy names are something like this FTBPresentsDirewolf20112Icon, CurseForge and Technic ones are very similar to eachother curseforge_637584581193129752 / technic_1406454.
Although ATLauncher may suffer too but I can't find any modpack with dots in name on there