GH-4044 Implemented copy screenshots to the clipboard#4300
Merged
peterix merged 3 commits intoMultiMC:developfrom Jan 30, 2022
Merged
GH-4044 Implemented copy screenshots to the clipboard#4300peterix merged 3 commits intoMultiMC:developfrom
peterix merged 3 commits intoMultiMC:developfrom
Conversation
- Added context-menu entry - Ctrl+C keybind works as well - If multiple screenshots are selected, only the first one gets copied
Member
|
I'd call this 'copy image data', and only allow it with single selection. With both multiple selection and single selection, there should be a 'copy' that operates on the file level, not image data level. |
Contributor
|
related issue #4044 |
- Ctrl+C now copies the file instead of the image data - Renamed Copy to Copy Image
ghosty141
changed the title
Contributor
Author
Implemented in a97d0a3 and e9c52ec . What I noticed, the widebard still contains the item, can this also be changed based on the selection? |
Member
|
It should be possible? Sorry to keep you waiting, but I just got distracted and forgot. In any case, let's merge this and see what the dev build users think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One "issue" I noticed, should the switch-case that checks for the pressed key be rewritten to if-else since the check for Ctrl+C cannot be done using the switch?