Format-strings instead of string concatenation

[main--]

Does @Multiverse notify all MV-Devs? I hope so.

I would like to know your opinion about changes like this one:

Now:

message.sendMessages(teleporter, new String[]{"You don't have permission to teleport another player to a " + ChatColor.GREEN + destination.getType() + " Destination.", ChatColor.RED + "   (multiverse.teleport.other." + destination.getIdentifier() + ")"});

(taken from TeleportCommand.java @ 562de0f, just as example)

---

How I would like to change that:

message.sendMessages(teleporter, new String[] {String.format("You don't have permission to teleport another player to a %s%s Destination.", ChatColor.GREEN, destination.getType()), String.format("%s(multiverse.teleport.other.%s)", ChatColor.RED, destination.getIdentifier())});

[fernferret]

It does not. Honestly I'm pretty indifferent about these, On one hand, the first only needs one change if a format change is required, but the second is more easy to format as you can read the whole string and then do stuff.

So I say go for it.

[fernferret]

I've started doing this, but this is a biggie. However it will help a TON with localization, leaving open for a while (until most are fixed)

[fernferret]

Moved to Localization Milestone. We need to get a 2.3 out quick-faster than we did 2.2.