Skip to content

Conversation

@yemeen
Copy link
Member

@yemeen yemeen commented Jan 15, 2025

Add benchmarks to the repo to see when new code impacts run times.

Description

Used uv for the install so it's quicker and then saves benchmarks as an artifact after code has been pushed to main. Added make benchmark. Closes #41

Motivation and Context

Quick way to see changes in compute time.

How has this been tested?

tested artifact storage and benchmarks using this gist.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [ x] My code follows the code style of this project. (make clean)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (make html)
  • I have incremented the version number in the pyproject.toml file.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (make tests)
    N/A bc not changing the package itself.

@yemeen yemeen marked this pull request as ready for review January 15, 2025 20:56
@yemeen yemeen requested a review from lizliz as a code owner January 15, 2025 20:56
@lizliz lizliz merged commit d2ff49f into main Jan 16, 2025
3 checks passed
@yemeen yemeen deleted the benchmarks branch January 16, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add benchmark workflow

3 participants