Skip to content

rename xtasks binary to cargo ninja#20

Merged
MusicalNinjaDad merged 4 commits into
mainfrom
cargo_ninja
May 1, 2026
Merged

rename xtasks binary to cargo ninja#20
MusicalNinjaDad merged 4 commits into
mainfrom
cargo_ninja

Conversation

@MusicalNinjaDad
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The toml get -r Cargo.toml bin[0].name step will fail if bin is missing or there are multiple [[bin]] entries; consider adding a fallback to package.name or a clearer failure/validation step to avoid brittle releases.
  • Now that the binary is named cargo-ninja but the package.metadata.binstall.pkg-url still uses { name } (crate name) in the archive path, double-check the archive contents and naming so that binstall can still find the expected binary without manual renaming.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `toml get -r Cargo.toml bin[0].name` step will fail if `bin` is missing or there are multiple `[[bin]]` entries; consider adding a fallback to `package.name` or a clearer failure/validation step to avoid brittle releases.
- Now that the binary is named `cargo-ninja` but the `package.metadata.binstall.pkg-url` still uses `{ name }` (crate name) in the archive path, double-check the archive contents and naming so that binstall can still find the expected binary without manual renaming.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MusicalNinjaDad MusicalNinjaDad merged commit 0262153 into main May 1, 2026
19 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the cargo_ninja branch May 1, 2026 13:55
@MusicalNinjaDad MusicalNinjaDad linked an issue May 1, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename binary to cargo-ninja

1 participant