rename xtasks binary to cargo ninja#20
Merged
Merged
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
toml get -r Cargo.toml bin[0].namestep will fail ifbinis missing or there are multiple[[bin]]entries; consider adding a fallback topackage.nameor a clearer failure/validation step to avoid brittle releases. - Now that the binary is named
cargo-ninjabut thepackage.metadata.binstall.pkg-urlstill uses{ name }(crate name) in the archive path, double-check the archive contents and naming so that binstall can still find the expected binary without manual renaming.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `toml get -r Cargo.toml bin[0].name` step will fail if `bin` is missing or there are multiple `[[bin]]` entries; consider adding a fallback to `package.name` or a clearer failure/validation step to avoid brittle releases.
- Now that the binary is named `cargo-ninja` but the `package.metadata.binstall.pkg-url` still uses `{ name }` (crate name) in the archive path, double-check the archive contents and naming so that binstall can still find the expected binary without manual renaming.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.