Skip to content

Fix missing bins#25

Merged
MusicalNinjaDad merged 2 commits into
mainfrom
fix_missing_bins
May 1, 2026
Merged

Fix missing bins#25
MusicalNinjaDad merged 2 commits into
mainfrom
fix_missing_bins

Conversation

@MusicalNinjaDad
Copy link
Copy Markdown
Owner

  • temporarily use v0.2.2 which has published binaries, so we can binstall self in CI. (taiki uses stable chain for fallback and we don't compile with that)

@MusicalNinjaDad MusicalNinjaDad merged commit 09152ba into main May 1, 2026
12 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the fix_missing_bins branch May 1, 2026 18:20
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief inline comment in the workflow next to ninja-xtask@0.2.2 explaining why this older version is pinned and under what condition it can be updated/removed, so future maintainers don’t inadvertently change it.
  • The combined changelog header ## v0.2.4 & 0.2.5 makes it harder to see what changed in each version; consider splitting into separate sections for v0.2.4 and v0.2.5 and clarifying which changes apply to which version.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief inline comment in the workflow next to `ninja-xtask@0.2.2` explaining why this older version is pinned and under what condition it can be updated/removed, so future maintainers don’t inadvertently change it.
- The combined changelog header `## v0.2.4 & 0.2.5` makes it harder to see what changed in each version; consider splitting into separate sections for `v0.2.4` and `v0.2.5` and clarifying which changes apply to which version.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant