Fix missing bins#25
Merged
Merged
Conversation
Owner
MusicalNinjaDad
commented
May 1, 2026
- temporarily use v0.2.2 which has published binaries, so we can binstall self in CI. (taiki uses stable chain for fallback and we don't compile with that)
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief inline comment in the workflow next to
ninja-xtask@0.2.2explaining why this older version is pinned and under what condition it can be updated/removed, so future maintainers don’t inadvertently change it. - The combined changelog header
## v0.2.4 & 0.2.5makes it harder to see what changed in each version; consider splitting into separate sections forv0.2.4andv0.2.5and clarifying which changes apply to which version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment in the workflow next to `ninja-xtask@0.2.2` explaining why this older version is pinned and under what condition it can be updated/removed, so future maintainers don’t inadvertently change it.
- The combined changelog header `## v0.2.4 & 0.2.5` makes it harder to see what changed in each version; consider splitting into separate sections for `v0.2.4` and `v0.2.5` and clarifying which changes apply to which version.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.